Implement stop timeout #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
changed the base branch from
feat/add_performance_benchmark
to
maint/use_ansys_tools_path
greschd
force-pushed
the
maint/use_ansys_tools_path
branch
from
cd84cef
to
3dd7fcd
Compare
greschd
force-pushed
the
feat/use_stop_timeout_in_tests
branch
from
cd9763c
to
6f4fd92
Compare
greschd
force-pushed
the
maint/use_ansys_tools_path
branch
from
3dd7fcd
to
e800602
Compare
greschd
force-pushed
the
feat/use_stop_timeout_in_tests
branch
2 times, most recently
from
3bd86e4
to
ed3b6ee
Compare
|
This is a stacked PR on top of #190, but can be independently reviewed. |
|
Was the tear down performance critical? |
janvonrickenbach
approved these changes
May 16, 2023
For the benchmark (which starts 7 servers) it takes ~13s even when stopping them all in parallel. So not very critical, but annoying when testing iteratively. |
greschd
force-pushed
the
feat/use_stop_timeout_in_tests
branch
from
ed3b6ee
to
6f2663c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
timeoutparameter in thestopmethod forboth the
directanddocker_composelauncher.Set the timeout to 1 second in tests, to speed up tear-down.