Enhancement/temp dep&transient bc #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c' into enhancement/temp_dep&transient_bc
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
===========================================
+ Coverage 31.12% 81.97% +50.84%
===========================================
Files 182 182
Lines 63851 63968 +117
===========================================
+ Hits 19875 52435 +32560
+ Misses 43976 11533 -32443 |
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 16, 2024
PipKat
reviewed
Jan 25, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
…m/pyansys/pyaedt into Enhancement/temp_dep&transient_bc # Conflicts: # pyaedt/icepak.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
==========================================
- Coverage 81.51% 76.64% -4.88%
==========================================
Files 107 107
Lines 52366 52485 +119
==========================================
- Hits 42687 40225 -2462
- Misses 9679 12260 +2581 |
PipKat
reviewed
Feb 15, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
SMoraisAnsys
requested changes
Mar 8, 2024
Samuelopez-ansys
previously approved these changes
Mar 8, 2024
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add classes to ease the creation of temperature dependent and transient boundary assignments.
Until now, the creation of a boundary condition with advanced conditions (transient or temperature dependent) was not immediate:
With this PR I introduce a base class (and subclasses) to handle all this easily.
@Samuelopez-ansys @maxcapodi78 let me know if you have suggestions