Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/temp dep&transient bc #4062

Merged
merged 72 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from 55 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
9cdf067
add tests
lorenzovecchietti Jan 11, 2024
fdf324e
add classes that ease the creation of boundary dictionaries
lorenzovecchietti Jan 11, 2024
03b0f14
add classes that ease the creation of boundary dictionaries
lorenzovecchietti Jan 11, 2024
0f8e7dc
fix check
lorenzovecchietti Jan 11, 2024
313d970
enhance assign_stationary_wall to support new classes
lorenzovecchietti Jan 11, 2024
07df28d
enhance assign_stationary_wall to support new classes
lorenzovecchietti Jan 11, 2024
890c776
enhance assign_source to support new classes
lorenzovecchietti Jan 11, 2024
d631587
enhance assign_*_block to support new classes
lorenzovecchietti Jan 11, 2024
2d58838
enhance assign*_free_opening to support new classes
lorenzovecchietti Jan 11, 2024
237dbdb
enhance assign*_resistance to support new classes
lorenzovecchietti Jan 11, 2024
1971bb7
enhance assign_recirculation_opening to support new classes
lorenzovecchietti Jan 11, 2024
481ff2d
enhance assign_conducting_plate to support new classes
lorenzovecchietti Jan 11, 2024
9231d77
enhance assign_conducting_plate* to support new classes
lorenzovecchietti Jan 11, 2024
76388f5
Merge branch 'main' into enhancement/temp_dep&transient_bc
lorenzovecchietti Jan 11, 2024
03f2102
fix
lorenzovecchietti Jan 11, 2024
2dedd66
Merge remote-tracking branch 'origin/Enhancement/temp_dep&transient_b…
lorenzovecchietti Jan 11, 2024
ce1c380
Update Boundary.py
lorenzovecchietti Jan 11, 2024
82df985
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Jan 16, 2024
417d921
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
9af77ec
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
c1299c1
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
cd81d81
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
a00555d
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
3ac0f2e
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
07d37e1
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
1fab27e
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
5392836
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
73e65be
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
d440900
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
475ddb5
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
e54aab0
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
42af659
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
061ebf7
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
e661a19
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
f79e5f7
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
6822fae
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
6833bf3
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
ff8e517
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
d25f5a2
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
5eb70de
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
ffe65e8
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
6e8b8be
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
9108c44
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
b9b9d0c
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Jan 17, 2024
7bccd8f
Update pyaedt/modules/Boundary.py
lorenzovecchietti Jan 17, 2024
8c3ca08
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
9cbffc4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 17, 2024
7592bd5
Update pyaedt/icepak.py
lorenzovecchietti Jan 17, 2024
2f4b28e
Apply suggestions from code review
lorenzovecchietti Jan 17, 2024
02aa5bc
Apply suggestions from code review
lorenzovecchietti Jan 17, 2024
65e1637
fix docstring style
lorenzovecchietti Jan 17, 2024
c5093e5
improve coverage
lorenzovecchietti Jan 17, 2024
60cce84
fix input sanitizing
lorenzovecchietti Jan 17, 2024
b5b6d5d
fix tests
lorenzovecchietti Jan 17, 2024
2b7b375
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Jan 23, 2024
7c2c3a4
Apply suggestions from code review
lorenzovecchietti Jan 29, 2024
21e83e8
update docstring
lorenzovecchietti Jan 29, 2024
ac68cbe
Merge branch 'Enhancement/temp_dep&transient_bc' of https://github.co…
lorenzovecchietti Jan 29, 2024
cd18d2b
update docstring
lorenzovecchietti Jan 29, 2024
b254e9d
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Jan 29, 2024
5343106
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Feb 12, 2024
27782fa
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Feb 13, 2024
960123e
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Feb 15, 2024
de64fe7
Update pyaedt/modules/Boundary.py
lorenzovecchietti Feb 20, 2024
0f201f6
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Feb 20, 2024
846b401
Merge branch 'main' into Enhancement/temp_dep&transient_bc
Samuelopez-ansys Mar 8, 2024
3550cdb
Apply suggestions from code review
lorenzovecchietti Mar 8, 2024
1a5be51
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 8, 2024
011455d
Update _unittest/test_98_Icepak.py
lorenzovecchietti Mar 8, 2024
ca1377d
Merge branch 'main' into Enhancement/temp_dep&transient_bc
lorenzovecchietti Mar 8, 2024
084644b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 8, 2024
730f53c
fix test
lorenzovecchietti Mar 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
74 changes: 73 additions & 1 deletion _unittest/test_98_Icepak.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from pyaedt import Icepak
from pyaedt.generic.settings import settings
from pyaedt.modules.Boundary import BoundaryDictionary
from pyaedt.modules.Boundary import NativeComponentObject
from pyaedt.modules.Boundary import NetworkObject

Expand Down Expand Up @@ -1456,6 +1457,77 @@ def test_73_conducting_plate(self):
with pytest.raises(AttributeError):
self.aedtapp.assign_conducting_plate_with_conductance([box_face.id, "surfPlateTest"])

def test_74_native_component_load(self, add_app):
def test_74_boundary_conditions_dictionaries(self):
box1 = self.aedtapp.modeler.create_box([5, 5, 5], [1, 2, 3])
ds_temp = self.aedtapp.create_dataset(
"ds_temp3", [1, 2, 3], [3, 2, 1], is_project_dataset=False, xunit="cel", yunit="W"
)
bc1 = self.aedtapp.create_temp_dep_assignment(ds_temp.name)
assert bc1
assert bc1.dataset_name == "ds_temp3"
assert self.aedtapp.assign_solid_block(box1.name, bc1)

self.aedtapp.solution_type = "Transient"

ds_time = self.aedtapp.create_dataset(
"ds_time3", [1, 2, 3], [3, 2, 1], is_project_dataset=False, xunit="s", yunit="W"
)
bc2 = self.aedtapp.create_dataset_transient_assignment(ds_time.name)
rect = self.aedtapp.modeler.create_rectangle(self.aedtapp.PLANE.XY, [0, 0, 0], [20, 10])
assert bc2
assert self.aedtapp.assign_conducting_plate_with_resistance(rect.name, total_power=bc2)

cylinder = self.aedtapp.modeler.create_cylinder(0, [-10, -10, -10], 1, 50)
bc3 = self.aedtapp.create_sinusoidal_transient_assignment("1W", "3", "2", "0.5s")
assert bc3
assert self.aedtapp.assign_solid_block(cylinder.name, bc3)

bc4 = self.aedtapp.create_square_wave_transient_assignment("3m_per_sec", "0.5s", "3s", "1s", "0.5m_per_sec")
assert bc4
assert self.aedtapp.assign_free_opening(
self.aedtapp.modeler["Region"].faces[0].id, flow_type="Velocity", velocity=[bc4, 0, 0]
)

bondwire = self.aedtapp.modeler.create_bondwire([0, 0, 0], [1, 2, 3])
bc5 = self.aedtapp.create_linear_transient_assignment("0.01W", "5")
assert bc5
assert self.aedtapp.assign_solid_block(bondwire.name, bc5)

box2 = self.aedtapp.modeler.create_box([15, 15, 15], [1, 2, 3])
bc6 = self.aedtapp.create_exponential_transient_assignment("0W", "4", "2")
assert bc6
assert self.aedtapp.assign_power_law_resistance(
box2.name,
total_power=bc6,
power_law_constant=1.5,
power_law_exponent="3",
)

box = self.aedtapp.modeler.create_box([25, 25, 25], [1, 2, 3])
box.solve_inside = False
bc7 = self.aedtapp.create_powerlaw_transient_assignment("0.5kg_per_s", "10", "0.3")
assert bc7
assert self.aedtapp.assign_recirculation_opening(
[box.top_face_x.id, box.bottom_face_x.id],
box.top_face_x.id,
assignment_value=bc6,
flow_assignment=bc7,
start_time="0s",
end_time="10s",
)

with pytest.raises(AttributeError):
BoundaryDictionary("Temp Dep", "Linear")
with pytest.raises(AttributeError):
BoundaryDictionary("Temperature Dep", "Linear")
with pytest.raises(AttributeError):
ds1_temp = self.aedtapp.create_dataset(
"ds_temp3", [1, 2, 3], [3, 2, 1], is_project_dataset=True, xunit="cel", yunit="W"
)
bc1 = self.aedtapp.create_temp_dep_assignment(ds1_temp.name)
with pytest.raises(AttributeError):
bc1 = self.aedtapp.create_temp_dep_assignment("nods")
lorenzovecchietti marked this conversation as resolved.
Show resolved Hide resolved

def test_75_native_component_load(self, add_app):
app = add_app(application=Icepak, project_name=native_import, subfolder=test_subfolder)
assert len(app.native_components) == 1