MAINT: fix CI by fixing scipy and scikit-rf versions #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a side effect on scikit-rf 0.30.0 as it uses scipy without bounding the version and that method linspace, used by scikit-rf is no longuer available through scipy import in scipy 1.12.0. (see scikit-rf/scikit-rf#1005) Note: this should be 'reverted' later on to use scikit-rf new version that should fix that issue.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
===========================================
+ Coverage 31.08% 81.87% +50.78%
===========================================
Files 184 184
Lines 63968 63968
===========================================
+ Hits 19887 52373 +32486
+ Misses 44081 11595 -32486 |
This reverts commit 37218a5.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a side effect on scikit-rf 0.30.0 as it uses scipy without bounding the version and that method linspace, used by scikit-rf is no longuer available through scipy import in scipy 1.12.0. (see scikit-rf/scikit-rf#1005)
Note: this should be 'reverted' later on to use scikit-rf new version as it should fix the current issue.
Extra note: a commit revert is also added to this PR as it was added on main by mistake and is failing (see 37218a5)