-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are failing #1005
Comments
Wow, the tests are still a huge mess:
This does not seem related to my changes. It's more like a general issue.
@FranzForstmayr: Any ideas? |
It's caused by the new scipy version. |
That was it, thanks! |
CI installs the newest packages of dependencies unless specified otherwise. It seems that this was changed in the latest scipy release. |
Seems that scipy had a What I don't understand is what has changed to make this issue appear now. |
I don't think it was removed, at least it was able to import Python 3.12.1 (tags/v3.12.1:2305ca5, Dec 7 2023, 22:03:25) [MSC v.1937 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import scipy
>>> scipy.__version__
'1.11.4'
>>> from scipy import linspace
>>> Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from scipy import linspace
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: cannot import name 'linspace' from 'scipy' (/home/franz/.cache/pypoetry/virtualenvs/test-OHDMMxWo-py3.10/lib/python3.10/site-packages/scipy/__init__.py) There was no deprecation warning in 1.11, that's why we missed to change that earlier. |
Is it because of my fix to import |
Your fix is perfectly fine, but unreleased. So when installing via pip you'll get the old version which tries to import linspace from scipy. |
So then maybe a super quick version 0.30.1 release? We should probably take a bit more time to prepare v1.0.0. @jhillairet ? |
Yeah, I think so. Will prepare the next release asap. |
Setting the scipy version to 1.11.4 instead of 1.12 also worked for me. |
There is a side effect on scikit-rf 0.30.0 as it uses scipy without bounding the version and that method linspace, used by scikit-rf is no longuer available through scipy import in scipy 1.12.0. (see scikit-rf/scikit-rf#1005) Note: this should be 'reverted' later on to use scikit-rf new version that should fix that issue.
Pandas 3.0 will be requiring pyarrow:
https://pandas.pydata.org/pandas-docs/version/2.2.0rc0/whatsnew/v2.2.0.html#dedicated-string-data-type-backed-by-arrow-by-default
In #1004 all tests were failing because of various DeprecationWarnings due to this upcoming dependency.
I'm not sure what pandas version is being used in the tests or why this is warning is starting to occur now. Anyway, I've already added pyarrow to pyproject.toml for the test requirements in #1004, which solved the issue, but I thought it would be good to document this change here.
The text was updated successfully, but these errors were encountered: