-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACT: Fix Circuit in linux 2024 R1 #4589
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
…ix/circuit_linux_2024R1
@maxcapodi78 I defined active_design at desktop.py level because it is also used at this level, if you think it does not make sense, we can discuss. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
- Coverage 81.51% 81.51% -0.01%
==========================================
Files 110 110
Lines 53772 53841 +69
==========================================
+ Hits 43834 43887 +53
- Misses 9938 9954 +16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samuelopez-ansys Just wondering if there is a way to avoid the latency that such changes will add.
For example, the property oeditor
now contains
if is_linux and settings.aedt_version == "2024.1":
time.sleep(1)
self._odesktop.CloseAllWindows()
I've briefly looked into our code base and it seems that a lot of classes tend to access this oeditor
property. Could we have some cache mechanism to know that all windows are already closed and avoid this time.sleep(1)
call ?
@SMoraisAnsys I did not find a method in the AEDT API to get this information... it is impacting only Linux in 2024.R1. Ansys development team is checking how to fix this in issue in 2024R2. So we need to decide if we want Circuit in 2024R1 in Linux, or not :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I proposed a few changes though
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for handling the Linux issues and making it possible to work with Circuit !
Add a common method for active project and active design