Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase robustness of Line #43

Closed
RobPasMue opened this issue Sep 2, 2022 · 1 comment · Fixed by #54
Closed

Increase robustness of Line #43

RobPasMue opened this issue Sep 2, 2022 · 1 comment · Fixed by #54
Assignees
@RobPasMue
Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog

Comments

@RobPasMue
Copy link
Member

During our meeting with the DBU we realized that when building a LineSketch object we are not double checking that (for example):

  • The points are not the same
  • The units of the points should be checked (if they are different, fall back to PyGeometry's default units)
  • ...
@github-actions github-actions bot removed the PRIORITY label Sep 5, 2022
This was referenced Sep 5, 2022
Closed
Closed
@RobPasMue
Copy link
Member Author

Working on #34, #33 and #43 at the same time

@RobPasMue RobPasMue self-assigned this Sep 5, 2022
@RobPasMue RobPasMue mentioned this issue Sep 5, 2022
Merged
@RobPasMue RobPasMue linked a pull request Sep 5, 2022 that will close this issue
Implementing Line and Segment classes #54
Merged
@RobPasMue RobPasMue added the PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobPasMue RobPasMue

Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementing Line and Segment classes ansys/pyansys-geometry
1 participant
@RobPasMue