Add vector primitives #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i will add tests once the vectorUV and vector3D module gets ready after review. |
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
RobPasMue
reviewed
Aug 31, 2022
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
RobPasMue
reviewed
Aug 31, 2022
jorgepiloto
previously requested changes
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
approved these changes
Aug 31, 2022
RobPasMue
dismissed
jorgepiloto’s stale review
Dismissing review to allow for merging - the issue raised can not be solved. Otherwise we would fall in an infinite recursive loop. Thanks for bringing it up @jorgepiloto!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vector 3D and vector UV geometry primitives modules.