Torus class added as primitive geometry #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
reviewed
Aug 31, 2022
RobPasMue
reviewed
Aug 31, 2022
RobPasMue
requested changes
Aug 31, 2022
RobPasMue
reviewed
Sep 2, 2022
Comment on lines
+11
to
+23
| Parameters | ||
| ---------- | ||
| origin : Point3D | ||
| Centered origin of the ``Torus``. | ||
| direction_x: Vector3D | ||
| X-plane direction. | ||
| direction_y: Vector3D | ||
| Y-plane direction. | ||
| major_radius: float | ||
| Major radius of ``Torus``. | ||
| minor_radius: float | ||
| Minor radius of ``Torus``. | ||
| """ |
There was a problem hiding this comment.
Once you update your branch, all these directions should be UnitVector3D
Comment on lines
+3
to
+5
| from ansys.geometry.core.primitives.point import Point3D | ||
| from ansys.geometry.core.primitives.vector import Vector3D | ||
|
|
There was a problem hiding this comment.
I think we should also provide setters if possible. As we are doing with other objects.
|
FYI. You have a lot of objects opened @chadqueen. Let's try to go one by one + integrate them with the changes we are implementing. I see in that sense that #41 is going to be conflictive... |
|
Replaced by #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores key configuration items via constructor.