Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torus class added as primitive geometry #27

Closed
wants to merge 5 commits into from
Closed

Conversation

chadqueen
Copy link
Contributor

@chadqueen chadqueen commented Aug 31, 2022

Stores key configuration items via constructor.

origin : Point3D
    Centered origin of the ``Torus``.
dir_x: Direction
    X-plane direction.
dir_y: Direction
    Y-plane direction.
major_radius: float
    Major radius of ``Torus``.
minor_radius: float
    Minor radius of ``Torus``.

@github-actions github-actions bot added the enhancement New features or code improvements label Aug 31, 2022
@chadqueen chadqueen linked an issue Aug 31, 2022 that may be closed by this pull request
Comment on lines +11 to +23
Parameters
----------
origin : Point3D
Centered origin of the ``Torus``.
direction_x: Vector3D
X-plane direction.
direction_y: Vector3D
Y-plane direction.
major_radius: float
Major radius of ``Torus``.
minor_radius: float
Minor radius of ``Torus``.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you update your branch, all these directions should be UnitVector3D

Comment on lines +3 to +5
from ansys.geometry.core.primitives.point import Point3D
from ansys.geometry.core.primitives.vector import Vector3D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also provide setters if possible. As we are doing with other objects.

@RobPasMue
Copy link
Member

FYI. You have a lot of objects opened @chadqueen. Let's try to go one by one + integrate them with the changes we are implementing. I see in that sense that #41 is going to be conflictive...

@RobPasMue RobPasMue marked this pull request as draft September 3, 2022 07:31
@chadqueen
Copy link
Contributor Author

Replaced by #57

@chadqueen chadqueen closed this Sep 5, 2022
@RobPasMue RobPasMue deleted the feat/torus branch September 6, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Torus Geometry 3D primitive
2 participants