-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: implement ellipse and circle geometries #19
Conversation
I will rebase as required for syncing this with its base branch. |
861ca0a
to
aa2e61b
Compare
You can update your branch @jorgepiloto =) |
I will focus only on the |
aa2e61b
to
a3e60ca
Compare
Let me improve the logic behind points generation for the circle and ellipse. I over complicated this too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing some tests and improved docstrings for the classmethods but apart from that it is looking really good! =)
b930f75
to
eaefd73
Compare
This just looks great @jorgepiloto =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jorgepiloto
I'll leave it pre-approved so that it can be merged whenever you decide. But it is looking great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is great.
Thanks for offering us some math @jorgepiloto . 😃
I'll connect in an hour or so @jorgepiloto if you want some help with something. Otherwise feel free to merge whenever it is ready! =) |
2de550f
to
17156b5
Compare
This branch can be merged once #16 is complete.
Example: