-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Point and Direction class #16
Conversation
This reverts commit 3fd4c09.
Point2D and Point3D was heavily tested. Direction was not since we are waiting on VectorXD implementation. Would love to hear your inputs. Specially regarding DirectionXD. Some questions:
|
Pinging @chadqueen @jorgepiloto @Revathyvenugopal162 and @MaxJPRey for discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some comments regarding the constructor. I think we should force only the usage of a list for the coordinates (same as NumPy), since this leads to:
- Uniform constructors
- Siplification of current constructor logic and tests
Please, tell me what you think about this.
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Following @jorgepiloto's suggestion, we will be reworking the Point class into Point2D and Point3D and making use of np.ndarray as parent class.