Rework Point and Direction class #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fd4c09.
github-actions
bot
added
maintenance
RobPasMue
requested review from
chadqueen,
jorgepiloto and
Revathyvenugopal162
|
Point2D and Point3D was heavily tested. Direction was not since we are waiting on VectorXD implementation. Would love to hear your inputs. Specially regarding DirectionXD. Some questions:
|
|
Pinging @chadqueen @jorgepiloto @Revathyvenugopal162 and @MaxJPRey for discussion |
jorgepiloto
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Just left some comments regarding the constructor. I think we should force only the usage of a list for the coordinates (same as NumPy), since this leads to:
- Uniform constructors
- Siplification of current constructor logic and tests
Please, tell me what you think about this.
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
MaxJPRey
reviewed
Aug 31, 2022
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
chadqueen
reviewed
Aug 31, 2022
jorgepiloto
approved these changes
Aug 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @jorgepiloto's suggestion, we will be reworking the Point class into Point2D and Point3D and making use of np.ndarray as parent class.