Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Line and Segment classes #54

Merged
merged 46 commits into from
Sep 8, 2022
Merged

Implementing Line and Segment classes #54

merged 46 commits into from
Sep 8, 2022

Commits on Sep 5, 2022

  1. Include additional checks

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d6e2c7a View commit details
    Browse the repository at this point in the history

  2. Small typos

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a8f7b78 View commit details
    Browse the repository at this point in the history

  3. Rework the Line and Segment classes

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    afe3725 View commit details
    Browse the repository at this point in the history

  4. Remove lne from sketching (WIP)

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1b33114 View commit details
    Browse the repository at this point in the history

  5. Removing test_sketch module

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3a6106e View commit details
    Browse the repository at this point in the history

  6. Adding test_line module

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6ae1ab2 View commit details
    Browse the repository at this point in the history

  7. Pre-commit checks

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1896eee View commit details
    Browse the repository at this point in the history

  8. Typo

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    19c773b View commit details
    Browse the repository at this point in the history

  9. Vector scalar multiplication

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    64590a1 View commit details
    Browse the repository at this point in the history

  10. Vector scalar multilication tests

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d74220c View commit details
    Browse the repository at this point in the history

  11. Line and segment bugs

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3372c55 View commit details
    Browse the repository at this point in the history

  12. Line and segment tests

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a3c74a5 View commit details
    Browse the repository at this point in the history

  13. Solving bugs + implementing error cases

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7d6e27f View commit details
    Browse the repository at this point in the history

  14. Pre-commit checks

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b78851b View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into feat/improve-line-segment

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8c4f724 View commit details
    Browse the repository at this point in the history

  16. Including version docstring

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    5df777a View commit details
    Browse the repository at this point in the history

  17. Typo

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    680da21 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into feat/improve-line-segment

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    be92b26 View commit details
    Browse the repository at this point in the history

  19. Code suggestions from @MaxJPRey and @Revathyvenugopal162

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4c1408b View commit details
    Browse the repository at this point in the history

  20. Pre-commit checks

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a39679a View commit details
    Browse the repository at this point in the history

  21. Merge branch 'main' into feat/improve-line-segment

    @RobPasMue
    RobPasMue committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    be97d1a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'main' into feat/improve-line-segment

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    51fecc9 View commit details
    Browse the repository at this point in the history

  2. Adapting to main branch

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8ba272a View commit details
    Browse the repository at this point in the history

  3. Class calls broken in docs

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fd60bbc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/improve-line-segment

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cc62f2e View commit details
    Browse the repository at this point in the history

  5. Improved docstrings for shapes

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1bdb31b View commit details
    Browse the repository at this point in the history

  6. New checks and testing

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ffe256a View commit details
    Browse the repository at this point in the history

  7. Adding fundamental direction unit vectors

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    726e605 View commit details
    Browse the repository at this point in the history

  8. Adding base unit property to QuantityVectorXD

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    19579a2 View commit details
    Browse the repository at this point in the history

  9. Adapting shape classes and docstrings

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4e214e2 View commit details
    Browse the repository at this point in the history

  10. Testing base_unit property for QuantityVectorXD objects

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fb66ba2 View commit details
    Browse the repository at this point in the history

  11. Redoing line implementation

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    af704eb View commit details
    Browse the repository at this point in the history

  12. Testing line

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b2fac07 View commit details
    Browse the repository at this point in the history

  13. Adapting sketch to support lines and segments

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bb174ea View commit details
    Browse the repository at this point in the history

  14. Update src/ansys/geometry/core/misc/__init__.py

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    56638c5 View commit details
    Browse the repository at this point in the history

  15. Update src/ansys/geometry/core/misc/checks.py

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e2dbd5f View commit details
    Browse the repository at this point in the history

  16. Better tests for certain checks

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ae0358d View commit details
    Browse the repository at this point in the history

  17. Pre-commit

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    593973e View commit details
    Browse the repository at this point in the history

  18. Merge branch 'feat/improve-line-segment' of https://github.com/pyansy… 

    …s/pygeometry into feat/improve-line-segment
    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4bcd945 View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review 

    Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Chad Queen <chadqueen82@gmail.com>
    @RobPasMue @MaxJPRey @chadqueen
    3 people committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1ef6a63 View commit details
    Browse the repository at this point in the history

  20. Typo in modeling

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    45f91bf View commit details
    Browse the repository at this point in the history

  21. Zero-valued ndarray message

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    51d40d7 View commit details
    Browse the repository at this point in the history

  22. Code suggestions @MaxJPRey

    @RobPasMue
    RobPasMue committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    33d1404 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Code suggestions and testing

    @RobPasMue
    RobPasMue committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b59f7c0 View commit details
    Browse the repository at this point in the history

  2. Pre-commit

    @RobPasMue
    RobPasMue committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ad2586e View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary code

    @RobPasMue
    RobPasMue committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    dc797c4 View commit details
    Browse the repository at this point in the history