feat: Add polydata conversors to edges and faces #759
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage ? 91.95%
=======================================
Files ? 78
Lines ? 5554
Branches ? 0
=======================================
Hits ? 5107
Misses ? 447
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…/pyansys-geometry into feat/named-selections-plot
|
Stopping the development of this branch while we don't have the required info from the server side:
|
|
Once #655 is merged, I think we can proceed with this one |
|
#655 has been merged @AlejandroFernandezLuces - please continue work here |
for more information, see https://pre-commit.ci
…/pyansys-geometry into feat/named-selections-plot
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
- Coverage 89.94% 89.66% -0.28%
==========================================
Files 93 93
Lines 6780 6812 +32
==========================================
+ Hits 6098 6108 +10
- Misses 682 704 +22 ☔ View full report in Codecov by Sentry. |
| """ | ||
| Return the edge as polydata. | ||
|
|
||
| This is useful to represent the edge in a PyVista plotter. |
There was a problem hiding this comment.
| This is useful to represent the edge in a PyVista plotter. | |
| This method is useful to represent the edge in a PyVista plotter. |
| """ | ||
| Return the face as polydata. | ||
|
|
||
| This is useful to represent the face in a PyVista plotter. |
There was a problem hiding this comment.
| This is useful to represent the face in a PyVista plotter. | |
| This method is useful to represent the face in a PyVista plotter. |
| Face as polydata | ||
| """ | ||
| if self.surface_type != SurfaceType.SURFACETYPE_PLANE: | ||
| LOG.warning("Only planes surfaces are supported") |
There was a problem hiding this comment.
| LOG.warning("Only planes surfaces are supported") | |
| LOG.warning("Only planes surfaces are supported.") |
| self.shape.geometry: Ellipse | ||
|
|
||
| else: | ||
| LOG.warning("Non linear edges not supported.") |
There was a problem hiding this comment.
| LOG.warning("Non linear edges not supported.") | |
| LOG.warning("Non-linear edges not supported.") |
Wiz Scan Summary
|
Add polydata methods to
EdgeandFaceclasses