Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshing queries updates #1579

Closed
seanpearsonuk opened this issue May 5, 2023 · 1 comment · Fixed by #1585
Closed

meshing queries updates #1579

seanpearsonuk opened this issue May 5, 2023 · 1 comment · Fixed by #1585
Assignees
Labels
enhancement New feature or request. Feature work invariably requires testing-team involvement

Comments

@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented May 5, 2023

  • change from camel case to snake case
    • I note that this is done in PR, thanks
  • reduce number of functions by grouping them and adding more arguments (gRPC)
    • E.g., all get_face_zones_* and get_face_zone_idlist_* can be merged and arguemts added (use the oneOf feature)
  • make interface easier to use e.g., in GetZonesOfType("velocity-inlet") and related functions the required argument values are obscure. We can add enums in the proto file.
  • add the new RPCs to the existing proto file and implement them in PyFluent, but do not document them and indicate that they are unsupported by 24R1.
@seanpearsonuk seanpearsonuk added the enhancement New feature or request. Feature work invariably requires testing-team involvement label May 5, 2023
@hpohekar
Copy link
Collaborator

hpohekar commented May 12, 2023

@seanpearsonuk

We are refactoring and reducing number of gRPC helper functions. (ADO PR related to T830826 )

We have improved error handling to get idea about allowed required argument values.

#1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Feature work invariably requires testing-team involvement
Projects
Development

Successfully merging a pull request may close this issue.

2 participants