Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshing queries refactoring, improved error handling and doc updates #1585

Merged
merged 24 commits into from May 15, 2023

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented May 9, 2023

image

---------------------------------------------------------------

image

---------------------------------------------------------------

image

---------------------------------------------------------------

image

@hpohekar hpohekar linked an issue May 9, 2023 that may be closed by this pull request
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented May 10, 2023

@hpohekar this is an observation rather than a criticism. The summary of each of these "service" objects focuses on the implementation: "wrapper over ... gRPC" rather than telling the reader what the "service" can offer them. This is bewildering for te average reader. #1586

@hpohekar
Copy link
Collaborator Author

@hpohekar this is an observation rather than a criticism. The summary of each of these "service" objects focuses on the implementation: "wrapper over ... gRPC" rather than telling the reader what the "service" can offer them. This is bewildering for te average reader. #1586

Right.

@hpohekar hpohekar linked an issue May 12, 2023 that may be closed by this pull request
@hpohekar hpohekar changed the title Meshing Queries doc update Meshing queries refactoring, improved error handling and doc updates May 12, 2023
@hpohekar hpohekar linked an issue May 12, 2023 that may be closed by this pull request
@hpohekar
Copy link
Collaborator Author

hpohekar commented May 15, 2023

@seanpearsonuk regarding following mesh utility function,

image

We have useful supporting function to guide user about allowed arguments to above function.

image

---------------------------------------

image

@seanpearsonuk
Copy link
Collaborator

@seanpearsonuk regarding following mesh utility function,

image

We have useful supporting function to guide user about allowed arguments to above function.

image

---------------------------------------

image

I believe that we should use enums for such things.

@hpohekar
Copy link
Collaborator Author

@seanpearsonuk

This PR is now ready and consistent with what we are offering in 23R2.

It contains all required meshing queries utility functions, tests and documentation.

We will implement new changes in next PR as per our latest discussion.

Thanks.

Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

streaming doc changes in follow-up

@hpohekar hpohekar merged commit 3b04ace into main May 15, 2023
17 checks passed
@hpohekar hpohekar deleted the doc/meshing_queries_docs_latest branch May 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary text for gRPC services is too technical meshing queries doc meshing queries updates
3 participants