Removing XPASS flag #1852
Merged
Removing XPASS flag #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
added
BUG
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
+ Coverage 85.68% 85.76% +0.07%
==========================================
Files 44 44
Lines 7840 7840
==========================================
+ Hits 6718 6724 +6
+ Misses 1122 1116 -6 |
germa89
requested review from
a team and
clatapie
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags were implemented in #957 and they were probably phased out in #942. Although the dates doesn't add up, I guess the change (between XFAIL to XPASS) must be related to one of the mentioned PR.
Close #1844