Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 10, 2022

Close #952 by implementing an iterative process.

Ok, it might be slow sometimes, but I think it is a reasonable approach for this case. I setup an upper limit at F60.12 for the float format.

@germa89 germa89 self-assigned this Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #957 (3900786) into main (d7d4985) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   73.06%   73.09%   +0.03%     
==========================================
  Files          39       39              
  Lines        5713     5720       +7     
==========================================
+ Hits         4174     4181       +7     
  Misses       1539     1539              

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking. I think the additional code complexity is worth the speed tradeoff here.

Would be nice to (eventually) get a gRPC message to pipe over this data.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 11, 2022

I believe most of the cases it will just go on the first iteration. It might not be necessary so many steps though. But as you said, it will be mostly a "one-time" thing.

@akaszynski akaszynski enabled auto-merge (squash) March 11, 2022 13:52
@akaszynski akaszynski merged commit 19da39c into main Mar 11, 2022
@akaszynski akaszynski deleted the feat/number-format-in-get_parameter_array branch March 11, 2022 13:56
@germa89 germa89 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flexibilize the format number when using _get_parameter_array

2 participants