Expose APDL Math New Feature - Kronecker product between two matrices/vectors

[kmkoshy]

Expose *KRON - Kronecker product (Newly Added feature in V23.2) for APDL Math
Description :
*KRON, M1, M2, M3
Computes the Kronecker product of two matrices/vectors

[codecov]

Codecov Report

Merging #1950 (bc85f99) into main (8e1d1e3) will increase coverage by 85.72%.
The diff coverage is 13.33%.

@@            Coverage Diff            @@
##           main    #1950       +/-   ##
=========================================
+ Coverage      0   85.72%   +85.72%     
=========================================
  Files         0       44       +44     
  Lines         0     7903     +7903     
=========================================
+ Hits          0     6775     +6775     
- Misses        0     1128     +1128     

[germa89]

Hi @kmkoshy

Thank you very much for your PR. This is a nice piece of work. Please address whenever you can the comments I left in it. Mainly increase unit testing.

[kmkoshy]

@germa89 Hi German !
I added the suggestions from the review and added more tests to improve coverage. But I see codecov is still failing.
Is this because we can run *KRON only on MAPDL V232 (we skip test after checking MAPDL version ) and we do not have workflows which run on V232 ?

[germa89]

@germa89 Hi German !
I added the suggestions from the review and added more tests to improve coverage. But I see codecov is still failing.
Is this because we can run *KRON only on MAPDL V232 (we skip test after checking MAPDL version ) and we do not have workflows which run on V232 ?

Indeed. It makes me think if we should implement something we cannot check on the CICD. Well, for now, because you run those tests locally, I think it should be fine. Let's approve this and merge.

Can you check if locally the coverage of the new added lines is fine? I presume you need to do that manually.