Expose Vector Scaling introduced in MAPDL V232

[kmkoshy]

MAPDL V232 can perform Scaling (*SCAL) of a AnsMat / AnsVec by a vector. (New feature)
Introduce this feature in PyMAPDL Math Library by updating the existing inplace multiplication function imul.
This Feature is available only in MAPDL V232 and above.

[codecov]

Codecov Report

Merging #1959 (55c0f28) into main (687e761) will decrease coverage by 0.13%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main    #1959      +/-   ##
==========================================
- Coverage   85.99%   85.87%   -0.13%     
==========================================
  Files          44       44              
  Lines        7877     7909      +32     
==========================================
+ Hits         6774     6792      +18     
- Misses       1103     1117      +14     

[germa89]

Looks good to me, but:

• Do we have to make any modifications to the original *SCAL function??
• You should test also when executed in a lower version than v23.2 (you should check the exception is raised).

Other than that. I'm happy with it :)

[germa89]

Same as #1950, @kmkoshy check that locally the tests passes and cover a decent amount of code lines. Once that is done, feel free to merge.

[clatapie]

A new MAPDL docker image will have to be added to test this new features daily but apart from that, it looks good to me 👍

[kmkoshy]

Looks good to me, but:

• Do we have to make any modifications to the original *SCAL function??
• You should test also when executed in a lower version than v23.2 (you should check the exception is raised).

Other than that. I'm happy with it :)

Hi @germa89 !

1. I was not able to find the implementation of *SCAL in any other pymapdl functions in math.py. If there is a original *SCAL function implemented elsewhere in the code , Ideally I would like to update this as well to handle vector scaling. Could you please share the function with me if there is such an implementation ?

2. I tested this with a lower version than v23.2 as per your suggestion.

3. I also checked codecov locally and was able to check that all lines are getting covered except one. (I hope this is okay) !

        else:
            raise TypeError(f"The provided type {type(val)} is not supported.")

[clatapie]

Looks good to me, but:

• Do we have to make any modifications to the original *SCAL function??
• You should test also when executed in a lower version than v23.2 (you should check the exception is raised).

Other than that. I'm happy with it :)

Hi @germa89 !

1. I was not able to find the implementation of *SCAL in any other pymapdl functions in math.py. If there is a original *SCAL function implemented elsewhere in the code , Ideally I would like to update this as well to handle vector scaling. Could you please share the function with me if there is such an implementation ?
2. I tested this with a lower version than v23.2 as per your suggestion.
3. I also checked codecov locally and was able to check that all lines are getting covered except one. (I hope this is okay) !

        else:
            raise TypeError(f"The provided type {type(val)} is not supported.")

Hi @kmkoshy,
The scal PyMAPDL function corresponds to the *SCAL MAPDL one. You can access to its implementation at the following file address: .src/ansys/mapdl/core/_commands/apdl/matrix_op.py.

[kmkoshy]

Looks good to me, but:

• Do we have to make any modifications to the original *SCAL function??
• You should test also when executed in a lower version than v23.2 (you should check the exception is raised).

Other than that. I'm happy with it :)

Hi @germa89 !

1. I was not able to find the implementation of *SCAL in any other pymapdl functions in math.py. If there is a original *SCAL function implemented elsewhere in the code , Ideally I would like to update this as well to handle vector scaling. Could you please share the function with me if there is such an implementation ?
2. I tested this with a lower version than v23.2 as per your suggestion.
3. I also checked codecov locally and was able to check that all lines are getting covered except one. (I hope this is okay) !

        else:
            raise TypeError(f"The provided type {type(val)} is not supported.")

Hi @kmkoshy, The scal PyMAPDL function corresponds to the *SCAL MAPDL one. You can access to its implementation at the following file address: .src/ansys/mapdl/core/_commands/apdl/matrix_op.py.

@clatapie Thanks Camille for pointing this out. I was not aware of this. I will update this as well. Thanks !

[clatapie]

You're welcome @kmkoshy! 😄

[clatapie]

Isn't it only true for MAPDL version >= 23.2?