Fix/logging

[Gryfenfer97]

• Add types to logging.py

• remove self assignation when using addfile_handler and add_stdout_handler

• Fix bug: Trying to instanciate a logger and redirect to a file with the default file name doesn't work

• Fix check for hasHandlers

• Fix call on _make_child_logger

[codecov]

Codecov Report

Merging #2118 (3301f4a) into main (09d55a4) will decrease coverage by 0.01%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   86.43%   86.43%   -0.01%     
==========================================
  Files          45       45              
  Lines        7971     7985      +14     
==========================================
+ Hits         6890     6902      +12     
- Misses       1081     1083       +2     

[germa89]

Some questions regarding:

Add types to logging.py

Good job!

remove self assignation when using addfile_handler and add_stdout_handler

I understand those assignations were redundant.

Fix bug: Trying to instantiate a logger and redirect to a file with the default file name doesn't work

Do you mean this line to_file or filename != FILE_NAME: ??

Fix check for hasHandlers

Thank you!

Fix call on _make_child_logger

This is the same as Fix check for hasHandlers, am I right?

[Gryfenfer97]

Fix bug: Trying to instantiate a logger and redirect to a file with the default file name doesn't work

Do you mean this line to_file or filename != FILE_NAME: ??

Exactly, yes

Fix call on _make_child_logger

This is the same as Fix check for hasHandlers, am I right?

Not really, L488 you called self._make_child_logger and passed it self as a first argument which wasn't expected

[germa89]

LGTM. Thank you Jamil!