Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing type annotation in python 3.8 #2162

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 4, 2023

Fix a bug introduced in ##2118 and reported in #2161.

Close #2161

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Jul 4, 2023
@germa89 germa89 self-assigned this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2162 (0f73d5f) into main (997e288) will increase coverage by 6.32%.
The diff coverage is 97.33%.

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
+ Coverage   80.82%   87.14%   +6.32%     
==========================================
  Files          44       45       +1     
  Lines        7489     7992     +503     
==========================================
+ Hits         6053     6965     +912     
+ Misses       1436     1027     -409     

@germa89 germa89 requested a review from clatapie July 4, 2023 17:06
@germa89 germa89 enabled auto-merge (squash) July 5, 2023 10:14
@germa89 germa89 merged commit 92fb454 into main Jul 5, 2023
22 checks passed
@germa89 germa89 deleted the fix/type-annotation-on-python3.8 branch July 5, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located when importing the package in python 3.8
3 participants