Small improvements to approver. #2229
Conversation
github-actions
bot
added
CI/CD
Codecov Report
@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
+ Coverage 86.43% 87.81% +1.37%
==========================================
Files 45 45
Lines 7971 8296 +325
==========================================
+ Hits 6890 7285 +395
+ Misses 1081 1011 -70 |
|
LGTM. |
| @@ -4,6 +4,10 @@ on: | |||
| issue_comment: | |||
| types: [created, edited] | |||
|
|
|||
| env: | |||
| # sintax: ("germa89" "author2") | |||
There was a problem hiding this comment.
Hi @germa89. We love this action and using in PyVista project too. I have one question in pyvista/pyvista#5314. Is there any reason why we cannot use comma(,) between authors? Thanks for your great job.
There was a problem hiding this comment.
Hi @tkoyama010 ! I am not sure why. I guess the GitHub run parse that env var again when passing it to the shell script that later execute for the job. But I don't know. I didn't really face the issue I think. Sorry for not being more helpful!
There was a problem hiding this comment.
Never mind. The author's comments are very valuable. I will test it when I get a chance.
There was a problem hiding this comment.
Can you post the link of those comments here?
There was a problem hiding this comment.
Sure. But I think it will be a little later to test it.
Links to comment and user.