Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin to code owners of LICENSE, CODE OF CONDUCT etc #5327

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Add admin to code owners of LICENSE, CODE OF CONDUCT etc #5327

merged 6 commits into from
Dec 12, 2023

Conversation

banesullivan
Copy link
Member

Some files that if modified, need to be reviewed by the @pyvista/admin team

tkoyama010
tkoyama010 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tkoyama010
tkoyama010 requested changes Dec 12, 2023
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
@banesullivan
Copy link
Member Author

Also, I want to try 😎: @pyvista-bot LGTM

@banesullivan @tkoyama010
Update .github/CODEOWNERS
4e78772 
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
@banesullivan
Copy link
Member Author

@pyvista-bot LGTM

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 12, 2023
@banesullivan
Copy link
Member Author

Shucks, @pyvista-bot LGTM isn't working

@banesullivan
Copy link
Member Author

Oh wait no... it may be working. I just checked the workflow logs and it is very backlogged

@tkoyama010
Copy link
Member

Oh wait no... it may be working. I just checked the workflow logs and it is very backlogged

@banesullivan We maybe need #5314 . @germa89 taught me that we should remove comma(,) in yaml file in ansys/pymapdl#2229 (comment) .

pyvista-bot
pyvista-bot previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@pyvista-bot pyvista-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because banesullivan said so in here 😬

@tkoyama010
Copy link
Member

✅ Approving this PR because banesullivan said so in here 😬

Oops, looks like it worked correctly even with the comma. Perhaps there were too many other Actions, causing a wait. @germa89 It seems to work fine even with the comma. Please refer to this in your project as well.

@banesullivan banesullivan enabled auto-merge (squash) December 12, 2023 06:25
@tkoyama010 tkoyama010 mentioned this pull request Dec 12, 2023
Merged
tkoyama010
tkoyama010 previously approved these changes Dec 12, 2023
View reviewed changes
@tkoyama010 tkoyama010 changed the title Admin code owners Add admin to code owners of LICENSE, paper and CODE OF CONDUCT Dec 12, 2023
@tkoyama010 tkoyama010 changed the title Add admin to code owners of LICENSE, paper and CODE OF CONDUCT Add admin to code owners of LICENSE, CODE OF CONDUCT etc Dec 12, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #5327 (1872118) into main (715de11) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5327   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         134      134           
  Lines       22717    22717           
=======================================
  Hits        21855    21855           
  Misses        862      862

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

🚀 Deployed on https://657833d8d69c1e3edfb73f46--tubular-marzipan-5e01ed.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 12, 2023 08:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2023 10:20 Inactive
@banesullivan banesullivan merged commit 52997f7 into main Dec 12, 2023
26 checks passed
@banesullivan banesullivan deleted the maint/admin-codeowners branch December 12, 2023 12:03
@banesullivan banesullivan mentioned this pull request Dec 14, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

@pyvista-bot pyvista-bot pyvista-bot left review comments

Assignees
No one assigned
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@banesullivan @tkoyama010 @pyvista-bot