Disabling database tests for v24.1 #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
germa89
added
CI/CD
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
- Coverage 87.92% 81.86% -6.06%
==========================================
Files 44 44
Lines 8453 8453
==========================================
- Hits 7432 6920 -512
- Misses 1021 1533 +512 |
|
LGTM |
clatapie
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
LGTM! The Vale version seems to be related to the Vale issue when looking at this PR.
Revert "trying adding HOME env var" This reverts commit 89a3ec6. Revert "testing value of home" This reverts commit e83e4a5. Revert "Using an older vale version" This reverts commit d55bd20. Revert "delete .vale.ini file" This reverts commit 352f283. Revert "Test if Vale is missing configuration" This reverts commit a3bd10b.
…nsys/pymapdl into fix/database-module-in-v24.1
germa89
commented
Oct 6, 2023
Gryfenfer97
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Disabling database tests for v24.1 * downgrade codespell * Test if Vale is missing configuration * delete .vale.ini file * Using an older vale version * testing value of home * trying adding HOME env var * trying adding HOME env var Revert "trying adding HOME env var" This reverts commit 89a3ec6. Revert "testing value of home" This reverts commit e83e4a5. Revert "Using an older vale version" This reverts commit d55bd20. Revert "delete .vale.ini file" This reverts commit 352f283. Revert "Test if Vale is missing configuration" This reverts commit a3bd10b. * Update .pre-commit-config.yaml * Skipping vale checks * skipping for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems latest v24.1 docker image fails when using database module.
Close #2382