Fixing vale warning

[clatapie]

Vale errors have appeared and need to be fixed:

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[codecov]

Codecov Report

Merging #2394 (db6da8e) into main (5040f12) will decrease coverage by 6.05%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
- Coverage   87.93%   81.88%   -6.05%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
- Hits         7433     6922     -511     
- Misses       1020     1531     +511     

[germa89]

I'm not sure why this happens. First time I saw it was in #2384

I suspect it is a bug in vale, because nothing really changed on our side, and they released a new patch version 16h ago: https://github.com/errata-ai/vale/releases/tag/v2.29.2

Pinging @Revathyvenugopal162 @RobPasMue

[Revathyvenugopal162]

@clatapie try adding mapdl and Mapdl in the vale accept.txt file. (may be the conflict between codespell and vale)

[germa89]

I'm not sure why this happens. First time I saw it was in #2384

I suspect it is a bug in vale, because nothing really changed on our side, and they released a new patch version 16h ago: https://github.com/errata-ai/vale/releases/tag/v2.29.2

Pinging @Revathyvenugopal162 @RobPasMue

Thinking it more thoughtful, because the latest vale version was failing silently, we might have been having this issue for a long time.

@clatapie try adding mapdl and Mapdl in the vale accept.txt file. (may be the conflict between codespell and vale)

It is already in accept.txt:

pymapdl/doc/styles/Vocab/ANSYS/accept.txt

Line 83 in e83e4a5

MAPDL

However the problem is that vale is analysis text inside code blocks, references, inline code, etc.

[clatapie]

An identical issue is raised in the PyMAPDL-Examples repository.

[germa89]

Overall I'm happy with this PR. Thank you for taking care of it.

Couple of remarks:

• The file .vale.ini has change completely, but actually only couple of lines have changed. I would suggest you to revert back that file to the version in main, and then do in the desired lines the changes you want. I would like to no "alter" the github history in the lines not actually changed.
• Changes in the headings/titles in troubleshoot.rst. I presume you did it because you want to keep consistency with other documents. I appreciate that. But because of that, we ran out of section headers. I rather change consistency but have headers and reference there. Furthermore, the ubuntu section I reference it a lot in projects and externally.

[germa89]

Small comment.

Ideally with the regex we are using we wouldn't have to make so many links changes (from two lines to one).
I am happy to keep those changes because it helps VSCode to highlight them in the editor.

Good work!

[github-actions]

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

[github-actions]

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓