Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding context to install/support jupyter lab #2470

Merged
merged 12 commits into from
Nov 6, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 2, 2023

Adding jupyter context

Close #2426

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 2, 2023
@germa89 germa89 added Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 2, 2023
@github-actions github-actions bot added Dependencies Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature and removed Enhancement Improve any current implemented feature labels Nov 2, 2023
@germa89 germa89 enabled auto-merge (squash) November 2, 2023 15:32
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2470 (6853750) into main (d89968a) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2470   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          44       44           
  Lines        8660     8660           
=======================================
  Hits         7254     7254           
  Misses       1406     1406           

@germa89
Copy link
Collaborator Author

germa89 commented Nov 3, 2023

I had to disable Google.Headings = NO because for some reason, it started to complain. Maybe they have fixed something upstream.

@germa89 germa89 disabled auto-merge November 3, 2023 19:43
@germa89
Copy link
Collaborator Author

germa89 commented Nov 6, 2023

Merging without passing coverage. It should pass, but I dont want to rerun CICD.

@germa89 germa89 merged commit 14f5461 into main Nov 6, 2023
27 of 28 checks passed
@germa89 germa89 deleted the feat/adding-context-for-jupyter branch November 6, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Jupyter and PyMAPDL
1 participant