Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not running auto approver by default #2576

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Not running auto approver by default #2576

merged 1 commit into from
Dec 19, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 19, 2023

  • Improving autoapprover so it does not run unless some user/comment is fulfilled. Moving the 'if' logic to the job level, instead of the step level.

@germa89 germa89 requested a review from a team as a code owner December 19, 2023 09:57
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Dec 19, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Dec 19, 2023 •
edited

Related to #2559 (comment) and pyvista/pyvista#5328

@germa89 germa89 enabled auto-merge (squash) December 19, 2023 10:01
@germa89
Copy link
Collaborator Author

germa89 commented Dec 19, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited

Codecov Report

Merging #2576 (d540934) into main (5e70f2f) will increase coverage by 1.42%.
Report is 6 commits behind head on main.
The diff coverage is 83.98%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
+ Coverage   82.49%   83.91%   +1.42%     
==========================================
  Files          44       46       +2     
  Lines        9048     9071      +23     
==========================================
+ Hits         7464     7612     +148     
+ Misses       1584     1459     -125

@germa89 germa89 merged commit bfd2b31 into main Dec 19, 2023
28 of 29 checks passed
@germa89 germa89 deleted the feat/improving-autoapprover branch December 19, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot