Optimize auto approval workflow #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @germa89 (Edit: Sorry to ping you a lot.) |
|
I may go spin this up in a dummy repo to test |
|
Confirmed in a sperate repo that this should do it! 
|
tkoyama010
approved these changes
Dec 12, 2023
| with: | ||
| review-message: ":white_check_mark: Approving this PR because [${{ github.event.comment.user.login }}](https://github.com/${{ github.event.comment.user.login }}) said so in [here](${{ github.event.comment.html_url }}) :grimacing:" | ||
| review-message: ":white_check_mark: Approving this PR because [${{ github.event.comment.user.login }}](https://github.com/${{ github.event.comment.user.login }}) said so in [here](${{ github.event.comment.html_url }}) :shipit:" |
There was a problem hiding this comment.
I didn't know about it.
On GitHub, what is the significance of the "Ship It" squirrel?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5328 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 134 134
Lines 22717 22717
=======================================
Hits 21855 21855
Misses 862 862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally sure if this will fix things, but I'm hoping that by moving the condtional from a workflow step to the job level, GitHub Actions will be able to parse whether or not it needs to spin up a runner or not.
At present, this workflow is eating up a ton of our CI bandwidth as it is spinning up a runner for every single PR comment and every time a comment is edited.
I went a step further and turned off runs for comment edits.