Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/print coms #870

Merged
merged 13 commits into from
Jan 31, 2022
Merged

Feat/print coms #870

merged 13 commits into from
Jan 31, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 31, 2022

Missing kwargs to launch_grpc to reuse start_parm and avoid passing keyword argument not allowed (print_com)

@germa89 germa89 added the Bug label Jan 31, 2022
@germa89 germa89 self-assigned this Jan 31, 2022
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #870 (b152193) into main (1859e7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files         172      172           
  Lines       10576    10576           
=======================================
  Hits         6152     6152           
  Misses       4424     4424           

@germa89 germa89 enabled auto-merge (squash) January 31, 2022 22:52
@germa89 germa89 merged commit 5112057 into main Jan 31, 2022
@germa89 germa89 deleted the feat/print-coms branch January 31, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants