-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit MAPDL at the end of each example #919
Conversation
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 72.49% 72.78% +0.29%
==========================================
Files 39 39
Lines 5682 5681 -1
==========================================
+ Hits 4119 4135 +16
+ Misses 1563 1546 -17 |
While I'm not fundamentally opposed to this, you may consider using our testing configuration that overrides
This way you can run through all examples using one instance of mapdl, rather than starting and stopping MAPDL for each test. Let me know if this testing configuration works. If you're still in favor of us including this, please include new lines at the end of each file. See: https://www.flake8rules.com/rules/W391.html |
@akaszynski One of the goals of our testing sessions is precisely to use separate mapdl pods for users. So using a single instance for all notebooks is definitely not appropriate. |
Sounds fair @cdan6, and this is better than patching all the files when copying the examples. Thanks for adding this and fixing the line endings! |
Local docbuilds fail. I'm looking into this. |
Thanks for taking care of this, @akaszynski. |
All examples starts launching MAPDL using launch_mapdl() method and should stop it properly at the end using mapdl.exit() method.
On our side, when we are running this examples inside jupyter lab, mapdl instances are created and never deleted.