fix(module:overlay): Interop delElementFrom() exception on page refresh #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anddrzejb
changed the title
anddrzejb
changed the title
15 tasks
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
…esh (#1008) * fix(module:overlay): page reload detection * fix(module:overlaytrigger): event handler on window resize remove on dispose
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
…esh (#1008) * fix(module:overlay): page reload detection * fix(module:overlaytrigger): event handler on window resize remove on dispose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
💡 Background and solution
Commit 6ff010c
Removes js event handler firing on window resize from
OverlayTrigger(this event handler is used to move the overlay as window resizes) on Dispose().Commit be31e33
When
Overlayis disposed, it tries to remove itself from the DOM. This works well when a page is changed using built in navigation or when a particular component is removed by the framework.This does not work well when the page is for example refreshed or new address is typed manually, because the dispose method is trying to remove DOM element that no longer exists.
To recreate:
npm starthttps"//localhost:5001components/tooltipThe problem was fixed by registering a js event
beforeunloadthat when fired changes a private flagbool _isReloading. If this flag is set totrue, the call to jsdelElementFromis not firing during disposal.☑️ Self Check before Merge