fix(module:table) Table exception on refresh #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for Ref.Id before any js operation on it
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
=========================================
- Coverage 5.47% 5.43% -0.04%
=========================================
Files 433 433
Lines 23284 23297 +13
=========================================
- Hits 1274 1266 -8
- Misses 22010 22031 +21
Continue to review full report at Codecov.
|
ElderJames
reviewed
Jan 25, 2021
ElderJames
approved these changes
Jan 25, 2021
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:overlay): remove obsolete js call check for Ref.Id before any js operation on it * fix(module:table): js interop exceptions on dispose * docs(module:slider): typo fix * docs(module:spider): typ
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:overlay): remove obsolete js call check for Ref.Id before any js operation on it * fix(module:table): js interop exceptions on dispose * docs(module:slider): typo fix * docs(module:spider): typ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
This issue can be demonstrated on the demo pages for tables, but should surface anytime
Tablecomponent is used (and actually any other component that usesOverlay). After page refresh, in about a minute a whole bunch of exceptions can be observed in the console (the log file is based on demo docs; it is pure 40kb text):tableExceptionsOnReload.log
馃挕 Background and solution
The fix is similar to PR #1008.
On top of that, there are also fixes to
Overlaycomponent. There were calls to no longer existing trigger elements based on no longer existing element classes (at least I could not find them and it does not really makes any sense to have those calls in my eyes). Also, there were calls to overlay container regardless if container was added - so extra check for that was added.After the changes no exceptions are thrown.
As a side note - it is likely that any component that has js interop calls during its
Dispose()method will have the same issue as theTablecomponent.鈽戯笍 Self Check before Merge