fix(module:menu): Wrap IconTemplate in corrected span #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wrap IconTemplate using span created by Icon component so InlineCollapse properly displays IconTemplate *docs: Added missing docs for IconTemplate
|
|
|
|
15 tasks
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
+ Coverage 25.38% 27.29% +1.91%
==========================================
Files 488 511 +23
Lines 32098 24481 -7617
Branches 0 233 +233
==========================================
- Hits 8148 6683 -1465
+ Misses 23950 17762 -6188
- Partials 0 36 +36
Continue to review full report at Codecov.
|
anddrzejb
approved these changes
Oct 8, 2021
ElderJames
approved these changes
Oct 8, 2021
ElderJames
added a commit
that referenced
this pull request
Oct 16, 2021
* fix(module:menu): Wrap IconTemplate in corrected span * wrap IconTemplate using span created by Icon component so InlineCollapse properly displays IconTemplate *docs: Added missing docs for IconTemplate * Update icontemplate.md Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:menu): Wrap IconTemplate in corrected span * wrap IconTemplate using span created by Icon component so InlineCollapse properly displays IconTemplate *docs: Added missing docs for IconTemplate * Update icontemplate.md Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:menu): Wrap IconTemplate in corrected span * wrap IconTemplate using span created by Icon component so InlineCollapse properly displays IconTemplate *docs: Added missing docs for IconTemplate * Update icontemplate.md Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Sep 6, 2022
* fix(module:menu): Wrap IconTemplate in corrected span * wrap IconTemplate using span created by Icon component so InlineCollapse properly displays IconTemplate *docs: Added missing docs for IconTemplate * Update icontemplate.md Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixes #2005
💡 Background and solution
When using the
IconTemplatein the Menu, collapsing the menu will not properly format the icon and text. WrappingIconTemplateRenderFragment in the proper span now allows the collapse to properly work without custom code from user.📝 Changelog
☑️ Self Check before Merge