Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IconTemplate for menu item #1879

Merged
merged 8 commits into from
Aug 27, 2021
Merged

Add IconTemplate for menu item #1879

merged 8 commits into from
Aug 27, 2021

Conversation

Guyiming
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

没有Issue

💡 Background and solution

考虑有如下代码:

<Menu Theme="MenuTheme.Dark" DefaultSelectedKeys=@(new[]{"1"}) Mode="MenuMode.Inline">
            <MenuItem Key="1" Icon="pie-chart">
                <MenuLink Href="" Match="NavLinkMatch.All">AA</MenuLink>
            </MenuItem>
            <MenuItem Key="2" Icon="desktop" RouterLink="systemctl" Title="BB">
            </MenuItem>
            <MenuItem Key="3">
                <IconFont Type="icon-c-sharp-l"></IconFont>
                <MenuLink Href="codeformat">CC</MenuLink>
            </MenuItem>
            <MenuItem Key="4">
                <Icon Type="desktop"></Icon>
                <MenuLink Href="fetchdata">DD</MenuLink>
            </MenuItem>
</Menu>

由于定义的CSS样式约束,缩起来时会产生如下不统一的效果:

1

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 26, 2021

@ElderJames
Copy link
Member

I prefer to add an IconTemplate for menu item so that you can add custom icons such as images, font icons etc.

@ElderJames ElderJames changed the title 使MenItem同时支持Icon和IconFont,解决当使用iconfont.cn图标后,缩起内嵌菜单导致按钮样式不统一的问题 Add IconFont for menu item Aug 26, 2021
@Guyiming
Copy link
Contributor Author

@ElderJames Hi, James. You mean like this?

<CascadingValue Value="this" IsFixed>
    <Tooltip Title="@content(this)" Placement="@PlacementType.Right" Disabled="TooltipDisabled">
        <Unbound>
            <li class="@ClassMapper.Class" role="menuitem" style=" @(PaddingLeft>0? $"padding-left:{PaddingLeft}px;":"") @Style" @onclick="HandleOnClick" @key="Key" @ref="context.Current">

                @if (IconTemplate != null)
                {
                    @IconTemplate
                }
                else if (Icon != null)
                {
                    <Icon Type="@Icon" />
                }

                @if (RouterLink == null)
                {
                    @content(this)
                }
                else
                {
                    <MenuLink Href="@RouterLink" Match="@RouterMatch">@content(this)</MenuLink>
                }
            </li>
        </Unbound>
    </Tooltip>
</CascadingValue>

Or you can write down your thoughts, maybe I can help implement them.

@ElderJames
Copy link
Member

@Guyiming That's right.

@Guyiming
Copy link
Contributor Author

@ElderJames Ok, I will close this PR, and make a new one.

@ElderJames
Copy link
Member

@Guyiming No need to close this PR, you can continue to commit to this branch.

@Guyiming Guyiming changed the title Add IconFont for menu item Add IconTemplate for menu item Aug 27, 2021
@Guyiming
Copy link
Contributor Author

@Guyiming No need to close this PR, you can continue to commit to this branch.

Done

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #1879 (04dd50b) into master (e106606) will increase coverage by 23.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1879       +/-   ##
===========================================
+ Coverage    0.00%   23.56%   +23.56%     
===========================================
  Files         478      495       +17     
  Lines       31211    23250     -7961     
  Branches        0      121      +121     
===========================================
+ Hits            0     5479     +5479     
+ Misses      31211    17768    -13443     
- Partials        0        3        +3     
Impacted Files Coverage Δ
components/menu/MenuItem.razor 0.00% <0.00%> (ø)
components/menu/MenuItem.razor.cs 0.00% <0.00%> (ø)
components/card/Card.razor 0.00% <0.00%> (ø)
components/form/Form.razor 0.00% <0.00%> (ø)
components/rate/Rate.razor 0.00% <0.00%> (ø)
components/spin/Spin.razor 0.00% <0.00%> (ø)
components/tree/Tree.razor 0.00% <0.00%> (ø)
components/menu/MenuLink.cs 0.00% <0.00%> (ø)
components/menu/MenuMode.cs 0.00% <0.00%> (ø)
components/steps/Step.razor 0.00% <0.00%> (ø)
... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e106606...04dd50b. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit bcf52d5 into ant-design-blazor:master Aug 27, 2021
ElderJames added a commit that referenced this pull request Aug 29, 2021
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
@knight1219
Copy link
Contributor

Is the IconTemplate working with the Collapse feature? I have the following menu and when collapsed I still see the text (I have more menu items but this is my static menu):

<Menu Theme="MenuTheme.Dark" DefaultSelectedKeys=@(new[]{"1"}) Mode="MenuMode.Inline"> <MenuItem Key="1" RouterLink="/"> <IconTemplate> <i class="fas fa-home"></i> </IconTemplate> <ChildContent> <span>Home</span> </ChildContent> </MenuItem> </Menu>
Expanded
image

Collapsed
image

@Guyiming
Copy link
Contributor Author

Guyiming commented Oct 6, 2021

@knight1219 try wrap your <i class="fas fa-home"></i> with <span>

@knight1219
Copy link
Contributor

Tried a span, didnt work. I went to the demo and pulled out the span that the Icon control creates and used that and it works.

<span role="img" class=" anticon anticon-container"> <i class="fas fa-home"></i> </span>

Should the IconTemplate RenderFragment be wrapped in this span from within the component so users don't have to try and worry about this and it "just works"?

@anddrzejb
Copy link
Member

@knight1219 Would you like to open a PR for that fix?

@knight1219
Copy link
Contributor

I could do that sure. It will be this weekend before I can dedicate any some time to it.

@anddrzejb
Copy link
Member

No problem. Any help is appreciated.

@knight1219
Copy link
Contributor

I had some time tonight so here is that PR #2006. It's my first one (ever), so be gentle

ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants