fix(module:select): it's incorrect to detect type this way, it throws when class inheritance is used #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when class inheritance is used
|
|
|
|
Codecov Report
@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
+ Coverage 27.95% 29.87% +1.91%
==========================================
Files 492 515 +23
Lines 32544 24789 -7755
Branches 0 242 +242
==========================================
- Hits 9099 7406 -1693
+ Misses 23445 17347 -6098
- Partials 0 36 +36
Continue to review full report at Codecov.
|
|
Thank you for contribute this, please sign the CLA first. |
ElderJames
approved these changes
Nov 30, 2021
knight1219
added a commit
to knight1219/ant-design-blazor
that referenced
this pull request
Dec 11, 2021
* 'master' of https://github.com/knight1219/ant-design-blazor: Allowing FormItem to be used in default EditForm refactoring EditContext to be injected properly by both AndDesign.Form and EditForm. fix(module: transfer): transfer button spacing (ant-design-blazor#2156) docs: Improve the API part about Form (ant-design-blazor#2150) chore: support IE and .net6 for server-side (ant-design-blazor#2119) docs: Update getting-started.zh-CN.md (ant-design-blazor#2145) docs(module: list): update the demos to use avatar template (ant-design-blazor#2147) fix(module: select): it's incorrect to detect type this way, it throws when class inheritance is used (ant-design-blazor#2121) fix(module: tree): Update check status when set `CheckedKeys` property (ant-design-blazor#2133) fix(module: radio): `Radio` in a group should always keep `Disabled` as same as `RadioGroup.Disabled` (ant-design-blazor#2142)
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
…s when class inheritance is used (#2121) Co-authored-by: Ocoka <somewhere@network>
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
…s when class inheritance is used (#2121) Co-authored-by: Ocoka <somewhere@network>
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
…s when class inheritance is used (#2121) Co-authored-by: Ocoka <somewhere@network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
it fix the #2120
💡 Background and solution
📝 Changelog
No visible changes
☑️ Self Check before Merge