Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: radio): Radio in a group should always keep Disabled #2142

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

LeaFrock
Copy link
Contributor

…as same as RadioGroup.Disabled

Fix issue #2141

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Radio in a group should always keep Disabled as same as RadioGroup.Disabled
🇨🇳 Chinese Radio作为组成员时Disabled属性应当始终与 RadioGroup.Disabled 一致

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 29, 2021

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2142 (38cb495) into master (0c794ef) will increase coverage by 1.99%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
+ Coverage   27.88%   29.88%   +1.99%     
==========================================
  Files         492      515      +23     
  Lines       32527    24783    -7744     
  Branches        0      242     +242     
==========================================
- Hits         9070     7406    -1664     
+ Misses      23457    17341    -6116     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/radio/Radio.razor.cs 84.61% <50.00%> (+8.20%) ⬆️
components/radio/RadioGroup.razor.cs 77.04% <50.00%> (+1.72%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 45.71% <0.00%> (-1.91%) ⬇️
... and 425 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c794ef...38cb495. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 4a1c6de into ant-design-blazor:master Nov 30, 2021
knight1219 added a commit to knight1219/ant-design-blazor that referenced this pull request Dec 11, 2021


* 'master' of https://github.com/knight1219/ant-design-blazor:
  Allowing FormItem to be used in default EditForm
  refactoring EditContext to be injected properly by both AndDesign.Form and EditForm.
  fix(module: transfer): transfer button spacing (ant-design-blazor#2156)
  docs: Improve the API part about Form (ant-design-blazor#2150)
  chore: support IE and .net6 for server-side (ant-design-blazor#2119)
  docs: Update getting-started.zh-CN.md (ant-design-blazor#2145)
  docs(module: list): update the demos to use avatar template (ant-design-blazor#2147)
  fix(module: select): it's incorrect to detect type this way, it throws when class inheritance is used (ant-design-blazor#2121)
  fix(module: tree): Update check status when set `CheckedKeys` property (ant-design-blazor#2133)
  fix(module: radio): `Radio` in a group should always keep `Disabled` as same as `RadioGroup.Disabled` (ant-design-blazor#2142)
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants