Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy .less files to wwwroot folder #2730

Merged

Conversation

paulsuart
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Related issue: #2694

💡 Background and solution

Added task to the gulp pipeline to include the .less files.

📝 Changelog

Low risk, I think. I'm not 100% that these files will end up in the .nupkg file.

Language Changelog
🇺🇸 English Altered gulp pipeline to include less files so they end up in /staticwebassets/less in the nuget package.
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

@dnfadmin
Copy link

dnfadmin commented Sep 20, 2022

CLA assistant check
All CLA requirements met.

@ElderJames
Copy link
Member

Thanks for the contribution @paulsuart , But I found some duplicate files, please exclude them when complicated.

image

@paulsuart
Copy link
Contributor Author

@ElderJames - good spot! I have pushed a fix.

@ElderJames ElderJames linked an issue Sep 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 39.99% // Head: 41.33% // Increases project coverage by +1.33% 🎉

Coverage data is based on head (cf80358) compared to base (e9a7d02).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   39.99%   41.33%   +1.33%     
==========================================
  Files         543      543              
  Lines       25697    25699       +2     
  Branches      260      261       +1     
==========================================
+ Hits        10278    10623     +345     
+ Misses      15379    15036     -343     
  Partials       40       40              
Impacted Files Coverage Δ
scripts/gulp/tasks/library.ts 0.00% <0.00%> (ø)
scripts/gulp/util/task-helpers.ts 0.00% <0.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 67.44% <0.00%> (-6.98%) ⬇️
components/core/Base/AntComponentBase.cs 50.00% <0.00%> (-3.58%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.63% <0.00%> (-2.64%) ⬇️
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 6e1d663 into ant-design-blazor:master Sep 24, 2022
@paulsuart paulsuart deleted the bug/2694-include-less-files branch September 24, 2022 09:56
YongQuan-dotnet pushed a commit to YongQuan-dotnet/ant-design-blazor that referenced this pull request Oct 9, 2022
* Copy .less files to wwwroot folder

* Copy all the non-empty less files, excluding the src folder which would duplicate some files.

Co-authored-by: Paul Suart <paulsuart@hellosmoove.com>
@paulsuart paulsuart mentioned this pull request Oct 10, 2022
15 tasks
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
* Copy .less files to wwwroot folder

* Copy all the non-empty less files, excluding the src folder which would duplicate some files.

Co-authored-by: Paul Suart <paulsuart@hellosmoove.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.LESS files not included in nuget package since v0.11.0
3 participants