Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/2694 keep empty patch files #2779

Merged

Conversation

paulsuart
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2694 (PR #2730 - earlier change excluded empty patch.less files, but they are required.)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Earlier change excluded empty patch.less files, but they are required. Removing the gulp task to exclude empty files.
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

paulsuart and others added 2 commits October 10, 2022 10:49
…ey are imported by entry.less files, so the less build breaks when they are missing.
@github-actions
Copy link

github-actions bot commented Oct 10, 2022

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 40.15% // Head: 41.60% // Increases project coverage by +1.45% 🎉

Coverage data is based on head (2cbf88f) compared to base (1a90a3b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
+ Coverage   40.15%   41.60%   +1.45%     
==========================================
  Files         544      544              
  Lines       25708    25702       -6     
  Branches      261      260       -1     
==========================================
+ Hits        10322    10694     +372     
+ Misses      15346    14968     -378     
  Partials       40       40              
Impacted Files Coverage Δ
scripts/gulp/tasks/library.ts 0.00% <ø> (ø)
scripts/gulp/util/task-helpers.ts 0.00% <ø> (ø)
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/date-picker/DatePicker.Razor.cs 77.48% <0.00%> (+0.66%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/date-picker/internal/DatePickerBase.cs 70.57% <0.00%> (+1.60%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit ac6dd12 into ant-design-blazor:master Oct 10, 2022
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
…do - they are imported by entry.less files, so the less build breaks when they are missing. (ant-design-blazor#2779)

Co-authored-by: Paul Suart <paulsuart@hellosmoove.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants