Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module: locale): wrong day order #2845

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

ocoka
Copy link
Contributor

@ocoka ocoka commented Oct 29, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Localization

🔗 Related issue link

💡 Background and solution

incorrect day order displayed on calendars and datepickers for russian locale, relates to changes made in commit: 894439a

📝 Changelog

Language Changelog
🇺🇸 English fix day order in calendar header for russian locale
🇨🇳 Chinese

relates to changes made in commit: 894439a
@github-actions
Copy link

github-actions bot commented Oct 29, 2022

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 43.87% // Head: 42.48% // Decreases project coverage by -1.39% ⚠️

Coverage data is based on head (e35d9d7) compared to base (97fdc2a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2845      +/-   ##
==========================================
- Coverage   43.87%   42.48%   -1.40%     
==========================================
  Files         544      544              
  Lines       25752    25756       +4     
  Branches      260      260              
==========================================
- Hits        11299    10942     -357     
- Misses      14413    14774     +361     
  Partials       40       40              
Impacted Files Coverage Δ
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
components/form/FormItem.razor.cs 43.31% <0.00%> (-29.94%) ⬇️
components/form/Form.razor 71.42% <0.00%> (-28.58%) ⬇️
components/form/FormItem.razor 60.00% <0.00%> (-20.00%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames
Copy link
Member

Thanks for contribution @ocoka , could you please tell me if the first Day Of Week in Russian is Monday?

@ocoka
Copy link
Contributor Author

ocoka commented Oct 31, 2022

Thanks for contribution @ocoka , could you please tell me if the first Day Of Week in Russian is Monday?

Hello, yes it is

@ElderJames
Copy link
Member

ElderJames commented Nov 1, 2022

Hey @Alexbits , do we need to fix ShortWeekDays for all locale files if the FirstDayOfWeek is not Sunday?

It seems that we need a document to explain the structure of locales, and to look for people of the corresponding culture to supplement them.

Or we use the language provided by System.Globalization if no corresponding value is available.

image

@Alexbits
Copy link
Contributor

Alexbits commented Nov 1, 2022

Hey @Alexbits , do we need to fix ShortWeekDays for all locale files if the FirstDayOfWeek is not Sunday?

@ElderJames Yes, the shortWeekDays should start with Sunday in the current implementation. I believe this can be improved with the use of System.Globalization as you say. I don't care about russian language though. I'm under russian rockets every day, they kill and rob people in Ukraine.

@ElderJames
Copy link
Member

@Alexbits Yes, we do oppose war, but not culture.

@ElderJames
Copy link
Member

@Alexbits Wish you peace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants