Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: datepicker): wrong day order and fallback to use globalization libaray when there is no day locale #2855

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Nov 3, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2851
follow up #2845

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 42.78% // Head: 44.21% // Increases project coverage by +1.42% 🎉

Coverage data is based on head (9ec4bb6) compared to base (29143db).
Patch coverage: 73.91% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
+ Coverage   42.78%   44.21%   +1.42%     
==========================================
  Files         544      545       +1     
  Lines       25756    25771      +15     
  Branches      260      261       +1     
==========================================
+ Hits        11020    11394     +374     
+ Misses      14696    14337     -359     
  Partials       40       40              
Impacted Files Coverage Δ
...date-picker/internal/DatePickerDatetimePanel.razor 70.78% <ø> (ø)
components/locale-provider/LocaleProvider.cs 53.84% <9.09%> (-0.70%) ⬇️
components/date-picker/locale/DatePickerLocale.cs 96.77% <77.77%> (-3.23%) ⬇️
components/core/Extensions/ArrayExtensions.cs 100.00% <100.00%> (ø)
components/date-picker/internal/DatePickerBase.cs 78.87% <100.00%> (+0.72%) ⬆️
...nts/date-picker/internal/DatePickerDatePanel.razor 69.23% <100.00%> (+0.93%) ⬆️
components/locale-provider/Locale.cs 100.00% <100.00%> (ø)
components/select/SelectLocale.cs 100.00% <100.00%> (+100.00%) ⬆️
components/table/TableLocale.cs 100.00% <100.00%> (+3.22%) ⬆️
components/transfer/TransferLocale.cs 100.00% <100.00%> (+70.00%) ⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 609f14b into master Nov 4, 2022
@ElderJames ElderJames deleted the fix/datepicker/locale-culture branch November 4, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URGENT: DatePicker day of week off by one
1 participant