Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: transfer): throw exception when it's in form #3015

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1029
add OnClear callback for #2979

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed Transfer throw exception when it's in Form
🇨🇳 Chinese 修复 Transfer 在 Form 内抛异常的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jan 16, 2023

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 44.25% // Head: 44.17% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (7682e9a) compared to base (c492d21).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
- Coverage   44.25%   44.17%   -0.08%     
==========================================
  Files         551      551              
  Lines       26340    26383      +43     
  Branches      263      263              
==========================================
- Hits        11656    11655       -1     
- Misses      14644    14688      +44     
  Partials       40       40              
Impacted Files Coverage Δ
components/transfer/Transfer.razor 0.00% <0.00%> (ø)
components/input/Input.cs 67.57% <75.00%> (+0.11%) ⬆️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-3.58%) ⬇️
components/table/Column.razor 0.00% <0.00%> (ø)
components/table/ActionColumn.razor 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit fca181d into master Jan 18, 2023
@ElderJames ElderJames deleted the fix/transfer-in-form branch January 18, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer search box causes exception if in form
1 participant