new feature: ReuseTabService method of UpdateTitle #3793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ElderJames
reviewed
Apr 12, 2024
| @@ -190,7 +190,15 @@ public void CreateTab(string pageUrl, RenderFragment? title = null) | |||
| _pageMap.TryAdd(pageUrl, new ReuseTabsPageItem() { Url = pageUrl, Title = title ?? pageUrl.ToRenderFragment(), CreatedAt = DateTime.MinValue }); | |||
| OnStateHasChanged?.Invoke(); | |||
| } | |||
|
|
|||
| public void UpdateTitle(string pageUrl, RenderFragment? title = null) | |||
There was a problem hiding this comment.
The title for this method is not opt-in.
|
We have Update() method to update all the state of reusetabs, so we don't need to update only title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
no issue link
💡 Background and solution
Sometimes, need UpdateTitle of reusetabs
📝 Changelog
Add UpdateTitle in reusetabservice
☑️ Self Check before Merge