-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : badgeribbon with preset color #791
Conversation
Text color was same as background color.
Added two ribbon examples with color set (preset and custom)
Thank you for contribution @boulix3 . Can you reproduce it in ant design react? We will not directly modify the less file. If there is a style issues, we will first go to ant design to submit the fixes. |
Ok, I didn't know the less files came from that repository. I cannot reproduce in react. It seems we are missing a span in the blazor version.
blazor version :
I'll try to implement this. |
Ok thanks! |
cc @Epictek |
Html content must be the same as in the react version
We don't change less files. They are copied from react version.
The less file is now unmodified. |
Thank you @boulix3 , please feel free to fix the test. |
Modified expected html to match markup from react version.
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
======================================
Coverage 3.67% 3.67%
======================================
Files 395 395
Lines 17481 17481
======================================
Hits 642 642
Misses 16839 16839
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
* Fix ribbon syle Text color was same as background color. * Ribbon documentation Added two ribbon examples with color set (preset and custom) * fix : badgeribbon html content Html content must be the same as in the react version * revert changes We don't change less files. They are copied from react version. * revert * tests: fix badgeribbon unit tests Modified expected html to match markup from react version. * Update tests/badge/RibbonTests.cs Co-authored-by: James Yeung <shunjiey@hotmail.com>
* Fix ribbon syle Text color was same as background color. * Ribbon documentation Added two ribbon examples with color set (preset and custom) * fix : badgeribbon html content Html content must be the same as in the react version * revert changes We don't change less files. They are copied from react version. * revert * tests: fix badgeribbon unit tests Modified expected html to match markup from react version. * Update tests/badge/RibbonTests.cs Co-authored-by: James Yeung <shunjiey@hotmail.com>
馃 This is a ...
馃敆 Related issue link
When using BadgeRibbon with a preset color, text color is the same as background color.
馃挕 Background and solution
Here is a snapshot of the bug
Solution : Fix less file.
馃摑 Changelog
Updated ribbon less file.
Added two ribbon examples with color set (preset and custom)
鈽戯笍 Self Check before Merge