Expose SubMenu's Placement #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Placement of SubMenu can now be changed and it will be set to BottomLeft or RightTop as before if you don't set it.
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
=========================================
- Coverage 5.53% 5.53% -0.01%
=========================================
Files 401 401
Lines 21337 21341 +4
=========================================
Hits 1182 1182
- Misses 20155 20159 +4
Continue to review full report at Codecov.
|
mutouzdl
approved these changes
Dec 25, 2020
This was
linked to
issues
Dec 25, 2020
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* Expose SubMenu's Placement The Placement of SubMenu can now be changed and it will be set to BottomLeft or RightTop as before if you don't set it. * Try fix #922 I'm not sure if it will bring new problems, but it solved my problem. I hope someone can help me review it to make sure it doesn't break other things. * Just optimize code style
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* Expose SubMenu's Placement The Placement of SubMenu can now be changed and it will be set to BottomLeft or RightTop as before if you don't set it. * Try fix #922 I'm not sure if it will bring new problems, but it solved my problem. I hope someone can help me review it to make sure it doesn't break other things. * Just optimize code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#916 #922
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge