Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing ref and types of the wrapped component #2471

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

bigbigDreamer
Copy link
Contributor

Add missing ref and types of the wrapped component

# Conflicts:
#	packages/plots/src/components/area/index.tsx
#	packages/plots/src/components/bar/index.tsx
#	packages/plots/src/components/base/index.tsx
#	packages/plots/src/components/bidirectional-bar/index.tsx
#	packages/plots/src/components/box/index.tsx
#	packages/plots/src/components/bullet/index.tsx
#	packages/plots/src/components/circlePacking/index.tsx
#	packages/plots/src/components/column/index.tsx
#	packages/plots/src/components/dual-axes/index.tsx
#	packages/plots/src/components/funnel/index.tsx
#	packages/plots/src/components/gauge/index.tsx
#	packages/plots/src/components/heatmap/index.tsx
#	packages/plots/src/components/histogram/index.tsx
#	packages/plots/src/components/line/index.tsx
#	packages/plots/src/components/liquid/index.tsx
#	packages/plots/src/components/mix/index.tsx
#	packages/plots/src/components/pie/index.tsx
#	packages/plots/src/components/radar/index.tsx
#	packages/plots/src/components/radial-bar/index.tsx
#	packages/plots/src/components/rose/index.tsx
#	packages/plots/src/components/sankey/index.tsx
#	packages/plots/src/components/scatter/index.tsx
#	packages/plots/src/components/stock/index.tsx
#	packages/plots/src/components/sunburst/index.tsx
#	packages/plots/src/components/tiny/area/index.tsx
#	packages/plots/src/components/tiny/column/index.tsx
#	packages/plots/src/components/tiny/line/index.tsx
#	packages/plots/src/components/tiny/progress/index.tsx
#	packages/plots/src/components/tiny/ring/index.tsx
#	packages/plots/src/components/treemap/index.tsx
#	packages/plots/src/components/venn/index.tsx
#	packages/plots/src/components/violin/index.tsx
#	packages/plots/src/components/waterfall/index.tsx
#	packages/plots/src/components/wordCloud/index.tsx
@bigbigDreamer
Copy link
Contributor Author

Changed from #2452 .

To solve #2434 ISSUE, @lxfu1 .

@bigbigDreamer
Copy link
Contributor Author

另外,很好奇 git commit 的时候 prettier 并没有执行哇。

我很怀疑不借助 husky 工具,在 commit 的时候能正常 prettier 吗?还是说我的姿势有问题。

image

@lxfu1
Copy link
Member

lxfu1 commented Mar 22, 2024

husky

需要husky工具,后续我测试一下

@bigbigDreamer
Copy link
Contributor Author

husky

需要husky工具,后续我测试一下

好的,代码已经 prettier 过,有空可以 review 下.

@lxfu1 lxfu1 merged commit 308f2b9 into ant-design:v2 Apr 19, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants