-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stepper #698
Merged
Merged
fix: stepper #698
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码的作用是处理数字输入框的值,并在值改变时触发onChange回调。
代码实现上有几个改进点:
isControlled方法是通过props上是否传入value来判断当前组件是受控还是非受控组件,这种方式是比较常见的做法,但可以优化一下:可以考虑在组件初始化时根据props上是否有value属性来设置isControlled标志,在之后不需要每次都重新计算。
由于这个组件是一个可控组件,因此要优先处理受控情况。在这里,首先判断组件是受控还是非受控状态,如果是非受控组件才会去更新组件的值。
判断needUpdate变量是否为false可以直接使用if (!needUpdate)的形式,这样会更加简洁。
当组件处于非受控状态时,更新操作没有被执行,这可能导致父组件和子组件的value值不一致,应该给出提示或者抛出异常。
至于代码是否存在风险,需要更多相关背景信息和上下文来确定。