fix: stepper #698
fix: stepper #698
Conversation
jc9702507
commented
Apr 23, 2023
jc9702507
commented
- 修改stepper受控问题 Stepper受控判断有问题 #697
|
🎊 PR Preview cd07084 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-698.surge.sh 🕐 Build time: 229.995s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return; | ||
| } | ||
| } | ||
| if (this.props.onChange) { | ||
| this.props.onChange(result, fmtEvent(this.props, e)); | ||
| } | ||
| } |
There was a problem hiding this comment.
这段代码的作用是处理数字输入框的值，并在值改变时触发onChange回调。
代码实现上有几个改进点：
-
isControlled方法是通过props上是否传入value来判断当前组件是受控还是非受控组件，这种方式是比较常见的做法，但可以优化一下：可以考虑在组件初始化时根据props上是否有value属性来设置isControlled标志，在之后不需要每次都重新计算。
-
由于这个组件是一个可控组件，因此要优先处理受控情况。在这里，首先判断组件是受控还是非受控状态，如果是非受控组件才会去更新组件的值。
-
判断needUpdate变量是否为false可以直接使用if (!needUpdate)的形式，这样会更加简洁。
-
当组件处于非受控状态时，更新操作没有被执行，这可能导致父组件和子组件的value值不一致，应该给出提示或者抛出异常。
至于代码是否存在风险，需要更多相关背景信息和上下文来确定。
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 24.04% 24.02% -0.03%
==========================================
Files 158 158
Lines 3331 3334 +3
Branches 871 873 +2
==========================================
Hits 801 801
Misses 2202 2202
- Partials 328 331 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
