fix(Steps): delete empty axml onTap #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview ffd9b78 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-711.surge.sh 🕐 Build time: 264.074s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| <import-sjs from="./index.sjs" name="utils" /> | |||
|
|
|||
| <view class="ant-steps ant-steps-{{direction}} {{className ? className : ''}}" style="{{style}}" onTap="onChange"> | |||
| <view class="ant-steps ant-steps-{{direction}} {{className ? className : ''}}" style="{{style}}"> | |||
| <view a:for="{{items}}" | |||
| class="ant-steps-item ant-steps-item-{{direction}} | |||
| {{index < current? 'ant-steps-item-finish' : ''}} | |||
There was a problem hiding this comment.
该代码补丁中的改动是将原有的onTap事件删除了，同时步骤条完成的状态ant-steps-item-finish被存储在样式中，用于确定当前步骤是否完成。代码风格看起来整洁清晰，但如果需要全面评估代码执行安全性和可读性，则需要更多上下文信息。
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 158 158
Lines 3334 3334
Branches 875 875
=======================================
Hits 801 801
Misses 2202 2202
Partials 331 331 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.