-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【BREAK CHANGE】Upgrade svg-sptite-loader #1283
Comments
right now we haven't upgrade svg-sprite-loader, just use the package.json version |
So you should tell user to install |
|
@Meeeeow sorry, my mistake, it's devDeps, will not be install when you npm install antd-mobile |
Nope, I think |
@Meeeeow whould you like to PR to help use upgrade svg-sprite-loader? |
Yep, maybe tonight |
38e4ae2?diff=unified -npm install svg-sprite-loader -D
+npm install svg-sprite-loader@0.3.1 -D |
close in favor of #1740 |
Notice
antd-mobile
Icon
所依赖的开源 webpack loadersvg-sprite-loader
最近从0.3
直接升级到了2.0
, 其配置方案发生了 break change.但由于此 loader 的版本由用户代码控制,而功能被 antd-mobile 和用户代码所共同依赖, antd-mobile 团队只能选择在
2.0
对其进行升级,请各位用户在antd-mobile@1.x
期间暂时不要升级svg-sprite-loader
,在项目里仍然使用svg-sprite-loader@0.3.x
即可。#1283Version
1.1.2
Environment
svg-sprite-loader@2, unrelated to other environments
Steps to reproduce
Toast.fail('Whoops')
What is expected?
Show toast
What is actually happening?
Browser throw an exception
Variable
type
in index.web.js with svg-sprite-loader 0.x is string,like "#fail"It's an object after upgrade to svg-sprite-loader 2.0+, include a
default
property,with sub property "id", "id" is the realtype
The text was updated successfully, but these errors were encountered: