Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【WIP】upgrade svg-sprite-loader to 2.0.6 #1311

Closed
wants to merge 1 commit into from
Closed

【WIP】upgrade svg-sprite-loader to 2.0.6 #1311

wants to merge 1 commit into from

Conversation

AvailCat
Copy link

@AvailCat AvailCat commented May 14, 2017

Updated by @paranoidjk
38e4ae2?diff=unified
已经更新了文档,暂时先别升级,这个升级方案要仔细评估能否向下兼容,业务有太多依赖

-npm install svg-sprite-loader -D
+npm install svg-sprite-loader@0.3.1 -D

这个升级要仔细考虑, 如 #1283 所说

我们要升级,必须要能做到新老配置都兼容

close #1283


First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style. (Error: spawn node ENOENT)
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@mention-bot
Copy link

@Meeeeow, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warmhug, @bccsafe and @paranoidjk to be potential reviewers.

@AvailCat
Copy link
Author

I'm not sure what happened 😢

@paranoidjk paranoidjk changed the title upgrade svg-sprite-loader to 2.0.6 【WIP】upgrade svg-sprite-loader to 2.0.6 May 15, 2017
@codecov
Copy link

codecov bot commented May 15, 2017

Codecov Report

Merging #1311 into master will decrease coverage by 6.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   68.38%   61.76%   -6.63%     
==========================================
  Files         229      219      -10     
  Lines        5108     4166     -942     
  Branches     1276     1226      -50     
==========================================
- Hits         3493     2573     -920     
+ Misses       1614     1592      -22     
  Partials        1        1
Flag Coverage Δ
#rn 63.12% <0%> (-7.54%) ⬇️
#web 60.37% <0%> (-5.51%) ⬇️
Impacted Files Coverage Δ
components/_util/getDataAttr.tsx 0% <0%> (-100%) ⬇️
components/range/index.tsx 0% <0%> (-100%) ⬇️
components/list-view/handleProps.tsx 0% <0%> (-100%) ⬇️
components/nav-bar/index.tsx 0% <0%> (-92.86%) ⬇️
components/picker-view/index.tsx 0% <0%> (-88.24%) ⬇️
components/table/index.tsx 0% <0%> (-69.57%) ⬇️
components/action-sheet/index.tsx 33.33% <0%> (-53.85%) ⬇️
components/carousel/index.tsx 43.16% <0%> (-46.31%) ⬇️
components/notice-bar/Marquee.tsx 0% <0%> (-27.78%) ⬇️
components/tag/index.tsx 59.32% <0%> (-25.3%) ⬇️
... and 349 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c611b74...a48a672. Read the comment docs.

@paranoidjk
Copy link
Contributor

@Meeeeow antd-mobile 已经进入 2.x 的开发期,分支如下:

https://github.com/ant-design/ant-design-mobile/tree/master -> 2.x
https://github.com/ant-design/ant-design-mobile/tree/1.x -> 1.x

请解决冲突。:smile

@paranoidjk paranoidjk force-pushed the master branch 2 times, most recently from a5629fa to 71e3ee7 Compare August 1, 2017 08:42
@paranoidjk
Copy link
Contributor

Thx for you pr, going to close since we decided to split svg icon to a single npm package in antd-mobile@2.0

@paranoidjk paranoidjk closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【BREAK CHANGE】Upgrade svg-sptite-loader
3 participants